Add patch-based support for deterministic sampler #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlelieLrt
added
enhancement
CharlelieLrt
requested changes
Jul 23, 2025
There was a problem hiding this comment.
Overall looks good to me. A few things to improve:
- Better tests that use actual networks rather than mock networks. Also need to test patching + lead-time + deterministic sampler.
- A possible bug in the embedding selector defined in the deterministic (and the stochastic) samplers --> to double-check
- A few details in the docs that will not render properly and that need to be fixed.
CharlelieLrt
changed the title
CharlelieLrt
requested changes
Jul 27, 2025
|
/blossom-ci |
CharlelieLrt
approved these changes
Jul 28, 2025
|
/blossom-ci |
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
added 2 commits
July 28, 2025 20:22
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
|
/blossom-ci |
…stic_sampler Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
|
/blossom-ci |
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
|
/blossom-ci |
coreyjadams
pushed a commit
to coreyjadams/physicsnemo
that referenced
this pull request
Aug 1, 2025
* add patching support for determinstic sampler * code cleanup and unit test update * use patching wraper and fix pytest functions * change utils.generative to utils.diffusion * set default to torch.float64 * do compilation in determinstic sampler * update * Identified and fixed critical bug in stochastic_sampler and deterministic_sampler Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Format CHANGELOG.md Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Implements wrapper selector to fix compile issues in tests Signed-off-by: Charlelie Laurent <claurent@nvidia.com> --------- Signed-off-by: Charlelie Laurent <claurent@nvidia.com> Co-authored-by: root <root@cw-dfw-h100-004-251-012.cm.cluster> Co-authored-by: Charlelie Laurent <84199758+CharlelieLrt@users.noreply.github.com> Co-authored-by: root <root@cw-dfw-h100-004-211-033.cm.cluster> Co-authored-by: root <root@cw-dfw-h100-004-270-026.cm.cluster> Co-authored-by: Charlelie Laurent <claurent@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch-base support for deterministic sampler
Description
Enable patch-base inference with deterministic sampler.
Stochastic sampler cleanup.
Closes #345 .
Checklist
Dependencies